[test] [llvm] Add bool to builder#8687
Closed
hughperkins wants to merge 3 commits into
Closed
Conversation
hughperkins
changed the title
Contributor
|
/rebase |
taichi-gardener
force-pushed
the
hp/add-bool-to-builder
branch
from
95fb641 to
bfe008b
Compare
Contributor
|
@bobcao3 PTAL |
Contributor
Author
|
Empirically, looks like I've stopped using the Builder, e.g. https://github.com/hughperkins/taichi/blob/45cbcd5ec8601c65138c900ed271b24ac1843a19/tests/cpp/ir/control_flow_graph_test.cpp#L72-L109 I'll close this PR (If I need the Builder bool (or if someone else does) I'll re-open it). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: #
Brief Summary
Add bool to builder. So you can do:
This will help me create tests for the cfg issue #8675
copilot:summary
Walkthrough
copilot:walkthrough